Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no internet connection #2370

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Nov 9, 2023

This fixes the issue detected by a user as below:

This was detected by a user posting the following:

Environment:

OSX 12.6.9
npm -v 8.19.3
node -v v18.13.0


Error. Kit will not run with internet connection disabled.

Error message:


Node.js v18.13.0
[nodemon] For missing modules try running `npm install`
Restarting kit...

You can manage your prototype at:
http://localhost:3000/manage-prototype

The Prototype Kit is now running at:
http://localhost:3000/

/Users/ian/Sites/xd/node_modules/govuk-prototype-kit/lib/utils/index.js:273
  const [, latestMajor, latestMinor, latestPatch, latestSuffix] = latestVersion.match(matcher)
                                                                                ^

TypeError: Cannot read properties of undefined (reading 'match')
    at hasNewVersion (/Users/ian/Sites/xd/node_modules/govuk-prototype-kit/lib/utils/index.js:273:81)
    at refreshPackageInfo (/Users/ian/Sites/xd/node_modules/govuk-prototype-kit/lib/plugins/packages.js:122:85)
    at async Promise.all (index 0)
    at async startPackageTracker (/Users/ian/Sites/xd/node_modules/govuk-prototype-kit/lib/plugins/packages.js:24:3)

Node.js v18.13.0
[nodemon] For missing modules try running `npm install`

@BenSurgisonGDS BenSurgisonGDS merged commit 3a36712 into main Nov 9, 2023
30 checks passed
@BenSurgisonGDS BenSurgisonGDS deleted the support-no-internet-connection branch November 9, 2023 18:47
@36degrees 36degrees linked an issue Mar 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kit version 13.14.0 will not run locally
2 participants